Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C8 templates validation #586

Merged
merged 3 commits into from
Feb 24, 2022
Merged

C8 templates validation #586

merged 3 commits into from
Feb 24, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Feb 17, 2022 •
edited
Loading

Closes #561

Implements JSON Schema validation for C8 templates.
Note that we also validate for an existing $schema attribute in any C8 template, that needs to reference our schema package in some way (@camunda/zeebe-element-templates-json-schema).

In particular it

  • adds @bpmn-io/element-templates-validator v0.5
  • adds the $schema attribute to existing C8 example templates
  • validates C8 templates against the JSON Schema + validates the defined $schema attribute

Snapshot from the Camunda Modeler WIP integration

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 17, 2022
@pinussilvestrus pinussilvestrus force-pushed the 561-cloud-templates-validation branch 3 times, most recently from 5fd27d5 to 2352b34 Compare February 21, 2022 13:46
@pinussilvestrus pinussilvestrus marked this pull request as ready for review February 22, 2022 08:03
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 22, 2022
@pinussilvestrus pinussilvestrus requested review from a team, marstamm, smbea, barmac and MaxTru and removed request for a team, marstamm and smbea February 22, 2022 08:03
MaxTru
MaxTru requested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Also like the extensive test coverage.

Just small comments

src/provider/cloud-element-templates/Validator.js Outdated Show resolved Hide resolved
test/spec/provider/cloud-element-templates/Validator.spec.js Show resolved Hide resolved
test/spec/provider/cloud-element-templates/fixtures/complex.json Show resolved Hide resolved
@pinussilvestrus
Copy link
Contributor Author

Great suggestions, I'll follow up shortly 👍

@fake-join fake-join bot merged commit 7f4b6f0 into master Feb 24, 2022
@fake-join fake-join bot deleted the 561-cloud-templates-validation branch February 24, 2022 09:58
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

@barmac barmac Awaiting requested review from barmac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement JSON Schema and Validator for C8 templates
2 participants
@pinussilvestrus @MaxTru